Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@altuner
Copy link
Contributor

@altuner altuner commented Jul 15, 2023

Description

What does this PR do?

PR checklist for examples

Check these items before merging the PR.

  • Each example contains a README file.
  • README documents all steps and variables required to run the example. The simplest way to confirm this is to follow the instructions on a clean machine.
  • README file contains the links to the official documentation with relevant configuration and to the metrics published if that is available.
  • Used images of apps and collectors have to be pinned, "latest" should never be used.
  • Evidences with screenshots provided from the reviewer.
  • Includes a file called metrics.csv with metrics produced by the example.
    The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
    Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.
  • Dashboard provided with example and put to the folder "dashboard" inside the example folder.
  • At least one screenshot of the proposed dashboard is included in this PR. If you're proposing substantive changes to queries or new queries then please ensure your screenshot shows relevant data.
  • All chart names in the dashboard are in Title case.
  • All query names in the dashboard are lower case letters, beginning the first query of each chart as "a" and proceeding alphabetically ... "b", "c", etcetera.
ex4 ex4 1 ex5 ex6 ex7 ex8 ex9 ex10 ex11 ex12 ex13

@altuner altuner changed the title databases examples and dashboards Azure databases examples and dashboards #1 Jul 15, 2023
@altuner altuner force-pushed the databases branch 2 times, most recently from 323690b to 789d67f Compare July 20, 2023 21:38
@altuner altuner changed the title Azure databases examples and dashboards #1 Azure databases examples and dashboards Jul 20, 2023
@altuner altuner marked this pull request as ready for review July 20, 2023 23:33
Copy link
Contributor

@nslaughter nslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two changes we discussed yesterday:
1.) Rename dirs called example to examples
2.) Since these Makefiles are the same, make Makefile.Common one and then import (e.g. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/aerospikereceiver/Makefile)

@nslaughter nslaughter merged commit e7f0467 into main Jul 27, 2023
@nslaughter nslaughter deleted the databases branch July 27, 2023 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants