Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@altuner
Copy link
Contributor

@altuner altuner commented Jul 28, 2023

Description

What does this PR do?
Dashbooards and examples for Azure Storage

PR checklist for examples

Check these items before merging the PR.

  • Each example contains a README file.
  • README documents all steps and variables required to run the example. The simplest way to confirm this is to follow the instructions on a clean machine.
  • README file contains the links to the official documentation with relevant configuration and to the metrics published if that is available.
  • Used images of apps and collectors have to be pinned, "latest" should never be used.
  • Evidences with screenshots provided from the reviewer.
  • Includes a file called metrics.csv with metrics produced by the example.
    The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
    Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.
  • Dashboard provided with example and put to the folder "dashboard" inside the example folder.
  • At least one screenshot of the proposed dashboard is included in this PR. If you're proposing substantive changes to queries or new queries then please ensure your screenshot shows relevant data.
  • All chart names in the dashboard are in Title case.
  • All query names in the dashboard are lower case letters, beginning the first query of each chart as "a" and proceeding alphabetically ... "b", "c", etcetera.
Screenshot 2023-07-27 at 6 22 10 PM Screenshot 2023-07-27 at 6 26 46 PM Screenshot 2023-07-27 at 6 22 27 PM Screenshot 2023-07-27 at 6 22 37 PM Screenshot 2023-07-27 at 6 22 44 PM Screenshot 2023-07-27 at 6 22 53 PM

@altuner altuner marked this pull request as ready for review July 28, 2023 01:34
@altuner altuner changed the title Storage Azure Storage examples and dashboards Jul 28, 2023
@nslaughter
Copy link
Contributor

I don't have reservations about merging these here. However, there is a difficulty in that we don't have a way to distinguish which of the dashboards are validated with live data and which we have good docs for - but we haven't been able to produce metrics in an example. And as these assets grow we need a way to distinguish that for purposes of gating inclusion in various parts of the product.

Copy link

@sbaum1994 sbaum1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just caught a few typos

@altuner altuner merged commit b93559b into main Aug 16, 2023
@altuner altuner deleted the storage branch August 16, 2023 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants