Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@altuner
Copy link
Contributor

@altuner altuner commented Aug 25, 2023

Description

What does this PR do?
kong example and dashboard

PR checklist for examples

Check these items before merging the PR.

  • Each example contains a README file.
  • README documents all steps and variables required to run the example. The simplest way to confirm this is to follow the instructions on a clean machine.
  • README file contains the links to the official documentation with relevant configuration and to the metrics published if that is available.
  • Used images of apps and collectors have to be pinned, "latest" should never be used.
  • Evidences with screenshots provided from the reviewer.
  • Includes a file called metrics.csv with metrics produced by the example.
    The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
    Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.
  • Dashboard provided with example and put to the folder "dashboard" inside the example folder.
  • At least one screenshot of the proposed dashboard is included in this PR. If you're proposing substantive changes to queries or new queries then please ensure your screenshot shows relevant data.
  • All chart names in the dashboard are in Title case.
  • All query names in the dashboard are lower case letters, beginning the first query of each chart as "a" and proceeding alphabetically ... "b", "c", etcetera.
Screenshot 2023-08-25 at 4 22 48 PM

Copy link

@sbaum1994 sbaum1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nslaughter Do you mind reviewing this one when you get the chance so we can close out https://lightstep.atlassian.net/browse/LS-49214

@sbaum1994 sbaum1994 requested a review from nslaughter August 28, 2023 16:23
Copy link
Contributor

@nslaughter nslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. kong directory goes in collector/kong instead of top-level
  2. Lightstep needs to be replaced per previous comments
  3. doesn't work if someone already has a kind cluster by that name

@nslaughter nslaughter merged commit 293d714 into main Sep 12, 2023
@nslaughter nslaughter deleted the kong branch September 12, 2023 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants