Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@altuner
Copy link
Contributor

@altuner altuner commented Sep 14, 2023

Description

What does this PR do?

Next azure dashboards group:
Microsoft.Compute/cloud services
Microsoft.Compute/cloudServices/roles
Microsoft.Compute/virtualmachineScaleSets
Microsoft.Compute/virtualMachineScaleSets/virtualMachines
Microsoft.ContainerInstance/containerGroups
Microsoft.ContainerInstance/containerScaleSets

PR checklist for examples

Check these items before merging the PR.

  • Each example contains a README file.
  • README documents all steps and variables required to run the example. The simplest way to confirm this is to follow the instructions on a clean machine.
  • README file contains the links to the official documentation with relevant configuration and to the metrics published if that is available.
  • Used images of apps and collectors have to be pinned, "latest" should never be used.
  • Evidences with screenshots provided from the reviewer.
  • Includes a file called metrics.csv with metrics produced by the example.
    The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
    Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.
  • Dashboard provided with example and put to the folder "dashboard" inside the example folder.
  • At least one screenshot of the proposed dashboard is included in this PR. If you're proposing substantive changes to queries or new queries then please ensure your screenshot shows relevant data.
  • All chart names in the dashboard are in Title case.
  • All query names in the dashboard are lower case letters, beginning the first query of each chart as "a" and proceeding alphabetically ... "b", "c", etcetera.
Screenshot 2023-09-13 at 4 57 07 PM Screenshot 2023-09-13 at 4 57 21 PM Screenshot 2023-09-13 at 4 57 42 PM Screenshot 2023-09-13 at 4 57 54 PM Screenshot 2023-09-13 at 4 58 03 PM Screenshot 2023-09-13 at 4 58 12 PM

@altuner altuner force-pushed the azure_dashboards_group5_2 branch from b4e46e9 to 5598715 Compare September 14, 2023 00:06
@nslaughter
Copy link
Contributor

Thanks for this! I have a couple of review comments, but have been looking into how we could use this variable name for project name when releasing in prebuiltdashboards. Unfortunately it's not compatible at the moment, so we need to use var.lightstep_project.

@altuner
Copy link
Contributor Author

altuner commented Sep 14, 2023

Thanks for this! I have a couple of review comments, but have been looking into how we could use this variable name for project name when releasing in prebuiltdashboards. Unfortunately it's not compatible at the moment, so we need to use var.lightstep_project.

@nslaughter addressed

Copy link
Contributor

@nslaughter nslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
We will use the lightstep_project a little longer. But that will change with rebrand shortly.

@nslaughter nslaughter merged commit 2f7d50b into main Sep 14, 2023
@nslaughter nslaughter deleted the azure_dashboards_group5_2 branch September 14, 2023 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants