Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@nslaughter
Copy link
Contributor

@nslaughter nslaughter commented Sep 14, 2023

The purpose of this PR is to make merging here simpler and focus more of the review effort where humans are required.

Committers will know how to make basic corrections prior to requesting review.

There are 3 types of changes:

  1. add files to run relevant github actions (.github/workflows/ci.yml and .golangci.yml)
  2. fix lint issues shown by files
  3. address scriveners errors in README of one integration example

@nslaughter nslaughter force-pushed the njs/pr-ci branch 7 times, most recently from 3357a2c to 367412e Compare September 14, 2023 22:21
Add linters

tweak go checks

add revised dashboard

update process
@nslaughter
Copy link
Contributor Author

I'm merging this to get some checks running.
Have requested reviews and waited > 20 hours, but the team that works in this repo is quite busy getting great results.
I have evaluated and accepted risk. Onward.

@nslaughter nslaughter enabled auto-merge (squash) September 15, 2023 20:27
@nslaughter
Copy link
Contributor Author

LGTM

@nslaughter nslaughter disabled auto-merge September 15, 2023 20:28
@nslaughter nslaughter merged commit c97fdf9 into main Sep 15, 2023
@nslaughter nslaughter deleted the njs/pr-ci branch September 15, 2023 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants