-
Notifications
You must be signed in to change notification settings - Fork 0
Add opa example #37
Add opa example #37
Conversation
nslaughter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good.
Only thing I would say here is instead of using the Makefile to use the opa image to run the build command. You could do this in an init container that the main opa depends on.
If this doesn't make sense then not a big deal and just let me know. I can write it out.
Co-authored-by: Nathan Slaughter <28688390+nslaughter@users.noreply.github.com>
I can apply this in the dashboard PR |
Can't think of many reasons why we would apply some improvements to this code in the dashboard PR. So I'm going to guess that your motivation is to optimize throughput by accepting some imperfections that we can touchup without breaking momentum. If that's the goal then I'm happy to cosign for that! |
|
When I revisited I realized a couple of things...
So for this there's no reason to mess with the bundle builder container. Users interested in the example will understand the opa setup from scratch separately. Thanks again. Really like how efficient we kept this one. |
nslaughter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
What does this PR do?
PR checklist for examples
Check these items before merging the PR.
metrics.csvwith metrics produced by the example.The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.