This repository was archived by the owner on Mar 6, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add opa server dashboard #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
nslaughter
suggested changes
Sep 19, 2023
Contributor
nslaughter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes
Please rename the folder to openpolicyagent. That's my interpretation of what your average Gopher would do, which should play well in our team. It's not a previously established standard you would have known.
Likewise I have suggested renaming the dashboard resource in a form that uses this app name and the correspondence in directory structure and resource names will be automatically checked soon (the script is in scripts/).
Other Notes
- I really like that you called this one and have done a nice job with it. This app complements our product value especially well and I have enjoyed learning more about it from reviewing these PRs.
- You have continued aggressively adopting dashboard features in your templates as they're rolled out... Fantastic!
- I'd like to see us actually use the chart description field for useful descriptions, but ATM not looking to hold up this PR on that point and very cautious generally about requiring any more overhead in the process for current objectives.
- One more point I loved here, you caught on to a mistake I made in handling the compose config, and fixed it in stride to keep us moving forward in a good way.
Really appreciate the delivery.
Co-authored-by: Nathan Slaughter <28688390+nslaughter@users.noreply.github.com>
nslaughter
approved these changes
Sep 19, 2023
Contributor
Author
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
What does this PR do?
Adds opa server dashboard
PR checklist for examples
Check these items before merging the PR.
metrics.csvwith metrics produced by the example.The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.