This repository was archived by the owner on Mar 6, 2025. It is now read-only.
Tools for automation #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nslaughter
suggested changes
Jun 29, 2023
Contributor
nslaughter
left a comment
nslaughter
left a comment
There was a problem hiding this comment.
- dashboard.tpl should go inside of another top-level directory called
templates - the Go files should go each be named main.go and be inside of directories with quasi descriptive names at
integrations/tools/cmd/, such as:integrations/tools/cmd/logs2metrics/main.go - the
.pyandrequirements.txtcan each move inside ofintegrations/tools/python/for now. - Update
Makefilefor path changes
Contributor
Author
|
@nslaughter should I create templates folder inside "tools", as we have decided to have services/platforms at the top level? |
altuner
force-pushed
the
tools
branch
2 times, most recently
from
8b9a661 to
bd141f1
Compare
Contributor
Author
|
@nslaughter comments addressed |
altuner
added a commit
that referenced
this pull request
Sep 25, 2023
nslaughter
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.