Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@nodehatch
Copy link
Contributor

@nodehatch nodehatch commented Sep 21, 2023

Description

What does this PR do?
feat: add istio collector k8s example

PR checklist for examples

Check these items before merging the PR.

  • Each example contains a README file.
  • README documents all steps and variables required to run the example. The simplest way to confirm this is to follow the instructions on a clean machine.
  • README file contains the links to the official documentation with relevant configuration and to the metrics published if that is available.
  • Used images of apps and collectors have to be pinned, "latest" should never be used.
  • Evidences with screenshots provided from the reviewer.
  • Includes a file called metrics.csv with metrics produced by the example.
    The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
    Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.
  • Dashboard provided with example and put to the folder "dashboard" inside the example folder.
  • At least one screenshot of the proposed dashboard is included in this PR. If you're proposing substantive changes to queries or new queries then please ensure your screenshot shows relevant data.
  • All chart names in the dashboard are in Title case.
  • All query names in the dashboard are lower case letters, beginning the first query of each chart as "a" and proceeding alphabetically ... "b", "c", etcetera.

@nodehatch nodehatch self-assigned this Sep 21, 2023
@nodehatch nodehatch force-pushed the feat/collector/istio branch 2 times, most recently from e673658 to 9b051cb Compare September 21, 2023 18:54
@nodehatch nodehatch marked this pull request as ready for review September 21, 2023 20:16
@nodehatch nodehatch changed the title feat: add istio collector k8s example Add istio collector k8s example Oct 6, 2023
@nslaughter nslaughter marked this pull request as draft October 11, 2023 16:18
@nslaughter
Copy link
Contributor

Converting to draft until it works as expected.

@nodehatch nodehatch force-pushed the feat/collector/istio branch from 0ae4369 to 3793dbe Compare October 16, 2023 18:55
@nodehatch nodehatch marked this pull request as ready for review October 16, 2023 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants