Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@hecomp
Copy link

@hecomp hecomp commented Sep 29, 2023

Description

What does this PR do?

  • Added pure storage flash array example.

*Pure FlashArray is a physical device. It's a hardware storage solution primarily designed with flash memory to provide high-speed, low-latency access to data. We cannot directly simulate the full functionality and behavior of a physical Pure FlashArray device using Docker. pure-fa-om-exporter interact with Pure FlashArray scraping endpoints, to monitor Pure Storage appliances.

PR checklist for examples

Check these items before merging the PR.

  • Each example contains a README file.
  • README documents all steps and variables required to run the example. The simplest way to confirm this is to follow the instructions on a clean machine.
  • README file contains the links to the official documentation with relevant configuration and to the metrics published if that is available.
  • Used images of apps and collectors have to be pinned, "latest" should never be used.
  • Evidences with screenshots provided from the reviewer.
  • Includes a file called metrics.csv with metrics produced by the example.
    The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
    Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.
  • Dashboard provided with example and put to the folder "dashboard" inside the example folder.
  • At least one screenshot of the proposed dashboard is included in this PR. If you're proposing substantive changes to queries or new queries then please ensure your screenshot shows relevant data.
  • All chart names in the dashboard are in Title case.
  • All query names in the dashboard are lower case letters, beginning the first query of each chart as "a" and proceeding alphabetically ... "b", "c", etcetera.

@nslaughter nslaughter marked this pull request as draft October 20, 2023 17:51
@nslaughter
Copy link
Contributor

This example still doesn't like the scrape config for the collector/prometheus receiver.

In logs it says...

otel-collector                 | * error decoding 'receivers': error reading configuration for "prometheus": prometheus receiver failed to unmarshal yaml to prometheus config: yaml: unmarshal errors:
otel-collector                 |   line 2: field headers not found in type config.ScrapeConfig
otel-collector                 |   line 13: field headers not found in type config.ScrapeConfig
otel-collector                 |   line 23: field headers not found in type config.ScrapeConfig
otel-collector                 |   line 33: field headers not found in type config.ScrapeConfig
otel-collector                 |   line 43: field headers not found in type config.ScrapeConfig

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants