Skip to content

list

  • list
  • 343321b
  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
  • Choose a tag to compare

  • list
  • 343321b
  • Choose a tag to compare

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@iredelmeier iredelmeier tagged this 05 Feb 18:01
It seems that we must stringify our ints before setting them in order
for them to actually get sent 😬 Without this, offsets won't get applied
to spans sent via proto.

To see this in action:
1. Emit spans over protobuf using an earlier version of the JS tracer
2. Open the trace in LightStep
3. Using the network tools, inspect the response body containing the
trace
4. Observe that the JS spans all have `timestamp_offset` == 0
5. Repeat steps 1-3 using the fixed tracer
6. Observe that after the fix, `timestamp_offset` is no longer always 0
Assets 2
Loading