[kinesis-dashboard] Updated query style #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecomp
suggested changes
Mar 3, 2023
hecomp
left a comment
hecomp
left a comment
There was a problem hiding this comment.
Need to add multiliner <<EOT EOT on below metrics.
| resource "lightstep_dashboard" "aws_kinesis_dashboard" { | ||
| project_name = var.lightstep_project | ||
| dashboard_name = "AWS Kinesis" | ||
| dashboard_description = "" |
modules/kinesis-dashboard/main.tf
Outdated
| query_name = "a" | ||
| display = "line" | ||
| hidden = false | ||
| query_string = "metric aws.kinesis.incoming_records_sum | delta | group_by [], sum" |
There was a problem hiding this comment.
Need to add multiliner <<EOT EOT on below metrics.
modules/kinesis-dashboard/main.tf
Outdated
| query_name = "b" | ||
| display = "line" | ||
| hidden = false | ||
| query_string = "metric aws.kinesis.incoming_bytes_sum | delta | group_by [], sum" |
modules/kinesis-dashboard/main.tf
Outdated
| query_name = "a" | ||
| display = "line" | ||
| hidden = false | ||
| query_string = "metric aws.kinesis.get_records_records_count | delta | group_by [], sum" |
modules/kinesis-dashboard/main.tf
Outdated
| query_name = "b" | ||
| display = "line" | ||
| hidden = false | ||
| query_string = "metric aws.kinesis.get_records_latency_max | latest | group_by [], sum" |
* [dynamo] Update dashboard * [dynamodb] Group table metrics by TableName
* added aws eks terraform dashboard * resolved fmt * resolved fmt * resolved fmt * modified readme * added lisc and readme * Splitted eks-dashboard to eks-pod-* and eks-node-* * resolved * modified eks node and pod * resolved fmt
Co-authored-by: githubsands <26752232+githubsands@users.noreply.github.com>
Checked to validate that we can upload the dashboard to Lightstep and get back the same. Co-authored-by: githubsands <26752232+githubsands@users.noreply.github.com>
* Updates RDS dashboards NOTE: we may have to revisit with expanded names The previous syntax was to add spaces in titles between lowercase and capitals. Checked this dashboard against output in the API to confirm we can upload and download the result. * terraform fmt --------- Co-authored-by: githubsands <26752232+githubsands@users.noreply.github.com>
* Demo lightstep aws rds (#16) * Testing aws rds terraform gen * /adds aurora-dashboard --------- Co-authored-by: Ryan Vacek <ryanvacek@Ryans-MacBook-Pro.local>
* [aws-step-functions] update db syntax * [step-functions] lint * added multiline <<EOT --------- Co-authored-by: Heber Silva <heber.silva@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.