Skip to content

Add php7.3 in travis tests#486

Merged
alexislefebvre merged 1 commit intoliip:2.xfrom
magnetik:php73
Jan 16, 2019
Merged

Add php7.3 in travis tests#486
alexislefebvre merged 1 commit intoliip:2.xfrom
magnetik:php73

Conversation

@magnetik
Copy link
Copy Markdown
Contributor

Not sure about adding the same EXTRA_PACKAGES as the one with php 7.2.
Maybe a comment should be added on why this is necessary.

@magnetik
Copy link
Copy Markdown
Contributor Author

Why isn't travis building this ? 🤔

@alexislefebvre
Copy link
Copy Markdown
Collaborator

EXTRA_PACKAGES is used to run tests with PHPCR, IIRC they are separated because they require older versions of dependencies.

@alexislefebvre alexislefebvre merged commit 8ffd957 into liip:2.x Jan 16, 2019
@alexislefebvre alexislefebvre mentioned this pull request Jan 16, 2019
@alexislefebvre
Copy link
Copy Markdown
Collaborator

Travis CI didn't trigger a build because of an error in the YAML file 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants