Cache resolver service argument order in readme#100
Merged
lsmith77 merged 1 commit intoliip:masterfrom Aug 22, 2012
Merged
Conversation
AbstractFilesystemResolver expects argument 1 to be an instance of Filesystem not an instance of Router.
Contributor
|
well the constructor isnt part of an interface as a result the order of parameters can be whatever someone chooses in their custom resolver. but i will merge it none the less since indeed most people will likely extend from this class and its custom to maintain the order of the parent constructor. |
lsmith77
added a commit
that referenced
this pull request
Aug 22, 2012
Cache resolver service argument order in readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractFilesystemResolver expects argument 1 to be an instance of Filesystem not an instance of Router.