Skip to content

Added option to disable cache_clearer#101

Merged
lsmith77 merged 1 commit intoliip:masterfrom
Spea:master
Aug 23, 2012
Merged

Added option to disable cache_clearer#101
lsmith77 merged 1 commit intoliip:masterfrom
Spea:master

Conversation

@Spea
Copy link

@Spea Spea commented Aug 23, 2012

Added a new option auto_clear_cache so the cache_clearer can be disabled.

This PR fixes #89

@travisbot
Copy link

This pull request passes (merged 939af6f1 into e01cb51).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove the liip_imagine.cache.clearer.class parameter from this file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

lsmith77 added a commit that referenced this pull request Aug 23, 2012
Added option to disable cache_clearer
@lsmith77 lsmith77 merged commit f67aaa4 into liip:master Aug 23, 2012
@travisbot
Copy link

This pull request passes (merged c4a6ccb into e01cb51).

@lsmith77
Copy link
Contributor

thought about this some more .. maybe auto_clear_cache should better be called clear_cacher?

@Spea
Copy link
Author

Spea commented Aug 24, 2012

not sure about this, in my opinion auto_clear_cache is easier to understand

@lsmith77
Copy link
Contributor

but it makes it sound like there is some complex logic that triggers a clear "automatically"

@Spea
Copy link
Author

Spea commented Aug 24, 2012

you're right, guess we should change it then. shall i create another PR for this?

@lsmith77
Copy link
Contributor

that would be very much appreciated!

@Spea
Copy link
Author

Spea commented Aug 24, 2012

btw. i think you meant cache_clearer instead of clear_cacher, didn't you?

@lsmith77
Copy link
Contributor

yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make cacheClearer an option

3 participants