deprecate the phpcr loader as CmfMediaBundle provides a better one now.#243
Merged
deprecate the phpcr loader as CmfMediaBundle provides a better one now.#243
Conversation
havvg
added a commit
that referenced
this pull request
Sep 18, 2013
deprecate the phpcr loader as CmfMediaBundle provides a better one now.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the DoctrinePHPCRLoader is almost the same as what we have in CmfMediaBundle, but using duck typing instead of an interface, and without providing the phpcr loader as a service.