Removed webRoot logic outside controller#28
Merged
lsmith77 merged 4 commits intoliip:masterfrom Oct 31, 2011
Merged
Conversation
Contributor
|
thx .. think i went off into a wrong direction in one of the refactorings, so your cleanup is very much appreciated. |
lsmith77
added a commit
that referenced
this pull request
Oct 31, 2011
Removed webRoot logic outside controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data loader should receive the
pathunaltered. The prepending of the webRoot should be done by the data loader itself (if the goal is to load files relative to the web root).