Extracted the abstract class Resolver from WebPathResolver#35
Merged
lsmith77 merged 2 commits intoliip:masterfrom Nov 10, 2011
sixty-nine:master
Merged
Extracted the abstract class Resolver from WebPathResolver#35lsmith77 merged 2 commits intoliip:masterfrom sixty-nine:master
lsmith77 merged 2 commits intoliip:masterfrom
sixty-nine:master
Conversation
Author
|
Maybe the Resolver class should be named AbstractResolver.. |
Contributor
|
hmm it should better be called |
Contributor
|
hmm maybe we should then also use https://github.com/knplabs/Gaufrette .. then again this adds another dependency |
Contributor
|
ok can you do the rename? a Gaufrette resolver could be something separately if a use case comes along |
Author
|
Yes, I'll do this today |
…moved the CacheManager injection from AbstractFilesystemResolver
lsmith77
added a commit
that referenced
this pull request
Nov 10, 2011
Extracted the abstract class Resolver from WebPathResolver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing files in the cache is a feature that will be used by most of the custom cache resolvers.
I extracted the store method as well as the CacheManager injection to an abstract Resolver class so that custom cache resolvers can share the code without extending WebPathResolver.