update template extension and helper names#41
Merged
lsmith77 merged 2 commits intoliip:masterfrom Dec 18, 2011
iampersistent:master
Merged
update template extension and helper names#41lsmith77 merged 2 commits intoliip:masterfrom iampersistent:master
lsmith77 merged 2 commits intoliip:masterfrom
iampersistent:master
Conversation
added 2 commits
November 29, 2011 00:53
…valacheImagineBundle
Contributor
|
i am not that familiar with the template helper .. but the entire point of the name is to be unique, it has no impact on the user of the Bundle if they are renamed? aka they should really always include the entire bundle name? |
lsmith77
added a commit
that referenced
this pull request
Dec 18, 2011
update template extension and helper names
Contributor
|
@lsmith77 the name is used to access them: <?php $view['liip_imagine']->applyFilter(); ?>For the Twig extension, the user should indeed never need to use the name. The compiled template does (so changing the name requires clearing the Twig cache) |
Contributor
|
ok thx .. thats what i figured in the end and which is why i merged the change .. conveniently we don't even document the php view helper :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a situation where I want to use parts of LiipImagineBundle with AvalacheImagineBundle in the same site. Right now, since both template extension and helpers have the same name, one cancels out the other. A simple name change fixes that.