increase test coverage report

[digitalkaoz]

by writing some new tests and applying missing covers annotations.

removed obsolete Binary/Loader/ExtendedFileSystemLoader.php since it could not work (wrong constructor and things) but i think its ok to remove

[makasim]

typo?

[digitalkaoz]

where? extended? http://phpunit.de/manual/current/en/appendixes.annotations.html#appendixes.annotations.covers

[makasim]

ok, I was not aware of it

[makasim]

removed obsolete Binary/Loader/ExtendedFileSystemLoader.php since it could not work (wrong constructor and things) but i think its ok to remove

that's ok to me. You can remove pdf to image transformer too. As it could not be used without ExtendedFileSystemLoader

[digitalkaoz]

mh, maybe reenable this feature, could be useful?

[makasim]

@digitalkaoz it has to be done. But in a different way, with events on origin image load. Like we did for resolve PRE_RESOLVE and POST_RESOLVE

[digitalkaoz]

ok removed it for now...have to dipe deeper into the current architecture to know what you mean by resolve events ;)

[makasim]

nothing special https://github.com/liip/LiipImagineBundle/tree/master/Events, https://github.com/liip/LiipImagineBundle/blob/master/Imagine/Cache/CacheManager.php#L195

[digitalkaoz]

so whats the goal? you request foo.pngwith filter pdf and want to have foo.pdf resolved?

[makasim]

you have a pdf source, it has to converted to image, later filteres applied to this image and stored to cache folder.

[makasim]

listener has to check that the source (by path extension or) is not image but pdf and convert it.

[digitalkaoz]

and it should be stored as pdf or as an image?

[makasim]

as image

[digitalkaoz]

it should be done in a seperate PR or this one?

[makasim]

@digitalkaoz it is completely out of this PR score.

[digitalkaoz]

mh, i implemented one as you described it, havent tested it out, but looks correct to me...

[digitalkaoz]

yes your right...lets do it in a separate PR...

[digitalkaoz]

what about merging this one?

[makasim]

@digitalkaoz sure, great work!