Skip to content

add composer.json#51

Merged
lsmith77 merged 3 commits intoliip:masterfrom
iampersistent:master
Mar 5, 2012
Merged

add composer.json#51
lsmith77 merged 3 commits intoliip:masterfrom
iampersistent:master

Conversation

@iampersistent
Copy link
Contributor

I can't promise it works, I'm just starting to play with composer. I'll get it working if its wrong.

composer.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong. First, master-dev does not exist anymore, and second, you should not depend on it (it would imply that you can guarantee the compatibility with any future state of the master branch)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, and the bundle depends on FrameworkBundle too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should just be "*" instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, * is bad too. Do you know any future release of Imagine to ensure that your current release of the bundle will always work with them ? No. So you need an upper bound on the constraint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I feel incredibly dumb :p That's pretty obvious, especially after you explain it a second time. Thanks. I'll fix it later today.

@lsmith77
Copy link
Contributor

lsmith77 commented Mar 3, 2012

ping ..

composer.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bundle is compatible with 2.1 too AFAIK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@iampersistent
Copy link
Contributor Author

@stof, would "2.0., 2.1." do the job on that?

@stof
Copy link
Contributor

stof commented Mar 4, 2012

@iampersistent no. the comma is a AND, not a OR. you need to expand the constraint manually for this: >=2.0,<2.2

@iampersistent
Copy link
Contributor Author

@stof, thanks, I appreciate you being patient and educating me

lsmith77 added a commit that referenced this pull request Mar 5, 2012
@lsmith77 lsmith77 merged commit df16075 into liip:master Mar 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants