Use of protected class properties in FilesystemLoader#54
Merged
lsmith77 merged 1 commit intoliip:masterfrom Mar 8, 2012
petrjaros:patch-2
Merged
Use of protected class properties in FilesystemLoader#54lsmith77 merged 1 commit intoliip:masterfrom petrjaros:patch-2
lsmith77 merged 1 commit intoliip:masterfrom
petrjaros:patch-2
Conversation
Contributor
|
can you explain the use case for when you require access to these properties? |
Contributor
Author
|
I have created a data loader class which is changing the name of source image to be cached which different name (there are some sensitive data in the image name - this data belong to the image, but I don't want to show the data to the users). So I have created class which extends FileSystemLoader. I need access to rootPath property in my class. I know that it's possible to make own constructor and save rootPath in another class property but it's duplicity I would like to awoid. |
Contributor
|
ok .. merging. |
lsmith77
added a commit
that referenced
this pull request
Mar 8, 2012
Use of protected class properties in FilesystemLoader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.