ensure that hardcoded filter formats are applied#86
Conversation
ensure that hardcoded filter formats are applied
|
I'm sorry, but this has to be reopened. We deployed this in our project and all hell broke loose :) Seems like my test case covered up a major flaw. The test project is updated with a change that demonstrates the problem. the flaw in the test case was that there was a source image, with the same name with both jpg and png extension. I've modified the names and in the test cases where we change the format, the controller throws an exception stating: Source image not found in "" |
|
it seems like there is a bit of a mess with the interaction between the cache manager, the resolver and the data loader. the data loaders have logic to look for files independent of their file extension, which is what we need here. i think this really needs some careful rethinking of the responsibilities of all of these classes and then making sure we use the right one in the right places .. not sure how soon i will get to this though :-/ can you open a new ticket for this please, referencing the old one? |
|
actually what you are noticing is the a "security measure" to prevent conversion to arbitrary formats: |
fixes #78
also reduces some code duplication and removes some ugly interaction between the resolver and cache manager