Skip to content

Better merging of collection types#42

Merged
dbu merged 9 commits intoliip:1.xfrom
brutal-factories:improvement/collection-types
Oct 26, 2023
Merged

Better merging of collection types#42
dbu merged 9 commits intoliip:1.xfrom
brutal-factories:improvement/collection-types

Conversation

@brutal-factories
Copy link
Contributor

This reopens the previous PR #40 , which got closed by an erroneous force-push on my part

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool, thanks a lot!

can you add a changelog entry that explains what the new functionality does? (and mentions that users don't need to change anything yet - apart from using PropertyTypeIterable instead of PropertyTypeArray when they extend functionality, to be forward compatible)

@dbu
Copy link
Member

dbu commented Oct 26, 2023

once i merged, i will merge 1.x to 2.x so that we can see only the changes for version 2.x in PR #43

@dbu dbu merged commit 41520e7 into liip:1.x Oct 26, 2023
@dbu
Copy link
Member

dbu commented Oct 26, 2023

awesome, thank you.

@dbu
Copy link
Member

dbu commented Oct 27, 2023

shall i tag a 1.x release for this?

@brutal-factories
Copy link
Contributor Author

shall i tag a 1.x release for this?

Yes, could you also bump up liip/serializer and liip/serializer-jms-adapter?

@dbu
Copy link
Member

dbu commented Oct 30, 2023

i will wait so we can first add the forward compatibility methods and add deprecations.

and for liip/serializer we should add the handling of generic traversable.

@dbu
Copy link
Member

dbu commented Nov 7, 2023

https://github.com/liip/metadata-parser/releases/tag/1.2.0

we should now upgrade liip/serializer to require parser ^1.2 and avoid the deprecations.

Spea pushed a commit to rebuy-de/metadata-parser that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants