Conversation
…ry filesystem checks for better performance we use function_exist before building the filename and checking if it exists. this gives a significant performance improvement when working with many objects of the same class. we considered an array cache of the function name, which seems to be faster still than the function_exists call, but not enough to justify the added complexity. numbers with 5M objects of the same type: Serialization timings conditions Timing (in ms) Improvement XHProf samplings 2.x 32'336 ---- serialize_singles.xhprof.txt 2.x + opcache 17'862 -44.8% serialize_singles.xhprof.txt with caching 12'929 -60.0% serialize_singles.xhprof.txt with caching +opcache 11'980 -63.0% serialize_singles.xhprof.txt function_exists instead of cache: +10.90% Deserialization timings conditions Timing (in ms) Improvement XHProf samplings 2.x 25'983 ---- deserialize_singles.xhprof 2.x + opcache 12'600 -51.5% deserialize_singles.xhprof.txt with caching 7'791 -70.0% deserialize_singles.xhprof.txt with caching + opcache 7'450 -71.3% deserialize_singles.xhprof.txt function_exists instead of cache: +9.15%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.