Skip to content

Add check if activation button already added in alert and menu#4

Merged
frostmorn merged 2 commits intomainfrom
menu_alert_activation_buttons
Sep 19, 2025
Merged

Add check if activation button already added in alert and menu#4
frostmorn merged 2 commits intomainfrom
menu_alert_activation_buttons

Conversation

@frostmorn
Copy link
Collaborator

@frostmorn frostmorn commented Sep 19, 2025 •
edited
Loading

current code allows to add same ActivationButton multiple times

mainMenu.addActivationButton(K_BTN_OK);
mainMenu.addActivationButton(K_BTN_OK);
mainMenu.addActivationButton(K_BTN_OK);
mainMenu.addActivationButton(K_BTN_OK);
mainMenu.addActivationButton(K_BTN_OK);

which would result in multiple time callback calls

this way we check on duplicates exactly in a moment we add new one

@frostmorn frostmorn added the bug Something isn't working label Sep 19, 2025
black-ghost-off
black-ghost-off approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@black-ghost-off black-ghost-off left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frostmorn frostmorn merged commit 5add5f8 into main Sep 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@black-ghost-off black-ghost-off black-ghost-off approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frostmorn @black-ghost-off