driver: remove AcceptConfig #3923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AcceptConfig` method is not meaningful because it is always followed by an invocation of `FillConfig`. Also, it contained remnant of `ResolveVMType` that is no longer supported in Lima v2.0, since PR 3901. (Discussed in the `#lima-gsoc` slack on Aug 8.) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Contributor
afbjorklund
approved these changes
Aug 28, 2025
Member
afbjorklund
left a comment
afbjorklund
left a comment
There was a problem hiding this comment.
Merging AcceptConfig and FillConfig sounds OK to me, naming is not 100% but
Adding Context everywhere is a bit tedious, but might as well do it now (in API)
norio-nomura
approved these changes
Aug 29, 2025
Contributor
opened #3932 |
Contributor
|
opened #3935 |
Contributor
|
Thanks! 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AcceptConfigmethod is not meaningful because it is always followed by an invocation ofFillConfig.Also, it contained remnant of
ResolveVMTypethat is no longer supported in Lima v2.0, since #3901.(Discussed in the
#lima-gsocslack on Aug 8.)Fix #3919
Fix #3920