Drop the log message that qemu is properly signed #3989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message is pretty much useless. It should at best be a debug message, but I don't think it is needed at all, as long as there is a log message when something is wrong. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
AkihiroSuda
reviewed
Sep 8, 2025
| logrus.Warn("If QEMU does not start up, you may have to sign the QEMU binary with the \"com.apple.security.hypervisor\" entitlement manually. See https://github.com/lima-vm/lima/issues/1742 .") | ||
| } | ||
| } else { | ||
| logrus.Infof("QEMU binary %q seems properly signed with the \"com.apple.security.hypervisor\" entitlement", qExe) |
Member
There was a problem hiding this comment.
Should be harmless to keep this as a debug-level log
Member
Author
There was a problem hiding this comment.
Should be harmless to keep this as a debug-level log
Yes, but why? How is this message ever useful?
I don't really mind keeping it (as debug), but I would like to understand the purpose of it.
AkihiroSuda
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message is pretty much useless. It should at best be a debug message, but I don't think it is needed at all, as long as there is a log message when something is wrong.