limactl prune --keep-referred: Do not skip template on failing driverutil.ResolveVMType()
#4016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
reviewed
Sep 10, 2025
…verutil.ResolveVMType()` `locationsFromLimaYAML()` should be called on the template, which fails `driverutil.ResolveVMType()` or not. It can be assumed that `driverutil.ResolveVMType()` does not affect any locations in the template. Prioritize that there is no omission in the current locations collection rather than changing locations by `driverutil.ResolveVMType()` in the future. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
force-pushed
the
do-no-skip-template-on--keep-referred
branch
from
659cffc to
83d1215
Compare
Contributor
Author
|
Thanks! 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locationsFromLimaYAML()should be called on the template, which failsdriverutil.ResolveVMType()or not.It can be assumed that
driverutil.ResolveVMType()does not affect any locations in the template.Prioritize that there is no omission in the current locations collection rather than changing locations by
driverutil.ResolveVMType()in the future.