Skip to content

Add global LIMA_BATS_ALL_TESTS_RETRIES variable #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

Add global LIMA_BATS_ALL_TESTS_RETRIES variable #4224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,14 +362,9 @@ jobs:
with:
template: templates/k8s.yaml
- name: "Run BATS k8s tests"
# Wish we could use BATS_TEST_RETRIES=3 as an environment variable here,
# but bats does not seem to support it.
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3.0.2
with:
timeout_minutes: 30
retry_on: error
max_attempts: 3
command: ./hack/bats/lib/bats-core/bin/bats --timing ./hack/bats/extras/k8s.bats
run: ./hack/bats/lib/bats-core/bin/bats --timing ./hack/bats/extras/k8s.bats
env:
LIMA_BATS_ALL_TESTS_RETRIES: 3

colima:
name: "Colima tests (QEMU, Linux host)"
Expand Down
12 changes: 11 additions & 1 deletion hack/bats/helpers/load.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ set -o errexit -o nounset -o pipefail
# The upstream PR https://github.com/bats-core/bats-core/pull/1118 is still open, so our submodule points to the PR commit.
export BATS_RUN_ERREXIT=1

# BATS_TEST_RETRIES must be set for the individual test and cannot be imported from the
# parent environment because the BATS test runner sets it to 0 before running the test.
BATS_TEST_RETRIES=${LIMA_BATS_ALL_TESTS_RETRIES:-0}
Copy link
Member

@AkihiroSuda AkihiroSuda Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update

lima/.github/workflows/test.yml

Lines 361 to 369 in 463f7e5

- name: "Run BATS k8s tests"
# Wish we could use BATS_TEST_RETRIES=3 as an environment variable here,
# but bats does not seem to support it.
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3.0.2
with:
timeout_minutes: 30
retry_on: error
max_attempts: 3
command: ./hack/bats/lib/bats-core/bin/bats --timing ./hack/bats/extras/k8s.bats

Copy link
Member

@AkihiroSuda AkihiroSuda Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @jandubois 🙏


# Known flaky tests should call `flaky` inside the @test to allow retries up to
# LIMA_BATS_FLAKY_TESTS_RETRIES even when the LIMA_BATS_ALL_TESTS_RETRIES is lower.
flaky() {
BATS_TEST_RETRIES=${LIMA_BATS_FLAKY_TESTS_RETRIES:-$BATS_TEST_RETRIES}
}

# Don't run the tests in ~/.lima because they may destroy _config, _templates etc.
export LIMA_HOME=${LIMA_BATS_LIMA_HOME:-$HOME/.lima-bats}

Expand Down Expand Up @@ -71,4 +81,4 @@ assert_output_lines_count() {
declare -A -g TEST_CONTAINER_IMAGES=(
["nginx"]="ghcr.io/stargz-containers/nginx:1.19-alpine-org"
["coredns"]="public.ecr.aws/eks-distro/coredns/coredns:v1.12.2-eks-1-31-latest"
)
)
Loading