Skip to content

Conversation

@alexandear
Copy link
Member

This PR refactors unexported function newStaticClientConfig in the hostagent/dns package.

The PR silents one modernize (will be enabled later) lint issue:

$ golangci-lint run --enable-only modernize

pkg/hostagent/dns/dns.go:74:3: stringsbuilder: using string += string in a loop is inefficient (modernize)
                s += fmt.Sprintf("nameserver %s\n", ip)
                ^

@jandubois
Copy link
Member

@alexandear I'm rerunning the tests right now, but if they continue to fail, then you may need to rebase your branch on the latest master.

Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
@alexandear alexandear force-pushed the refactor/dns-simplify-newStaticClientConfig branch from df51c83 to 38a94b3 Compare November 18, 2025 09:51
@alexandear
Copy link
Member Author

@jandubois rebased

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois added this to the v2.0.2 milestone Nov 19, 2025
@jandubois jandubois merged commit b1e6640 into lima-vm:master Nov 19, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants