Skip to content

Fix mismatch of signals for stopping external VMs #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2025
Merged

Fix mismatch of signals for stopping external VMs #4364

merged 1 commit into from
Nov 19, 2025
+1 −1

Conversation

@unsuman
Copy link
Contributor

@unsuman unsuman commented Nov 18, 2025

Fixes #4362

@unsuman
fix mismatch of signals for stopping external vms
084c4e2 
Signed-off-by: Ansuman Sahoo <anshumansahoo500@gmail.com>
@norio-nomura
Copy link
Contributor

norio-nomura commented Nov 19, 2025

With this change, DriverServer should be able to shut down gracefully.
As a result of the signal handler's role, ga.sock and others are expected to be cleaned up.
When limactl start is stopped by ctrl+C in the middle, it will be transmitted to the DriverServer side and ga.sock will not remain, which is the ideal that this change should bring.

jandubois
jandubois approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit ec1644b into lima-vm:master Nov 19, 2025
37 checks passed
@AkihiroSuda AkihiroSuda added this to the v2.0.2 milestone Nov 19, 2025
@norio-nomura
Copy link
Contributor

norio-nomura commented Nov 19, 2025

When limactl start is stopped by ctrl+C in the middle, it will be transmitted to the DriverServer side and ga.sock will not remain, which is the ideal that this change should bring.

Sorry, current implementation does not forward ctrl+C on limactl start.

@unsuman
Copy link
Contributor Author

unsuman commented Nov 19, 2025

I'll fix this in #4363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jandubois jandubois jandubois approved these changes

Assignees

No one assigned

Labels

easy-to-review

Projects

None yet

Milestone

v2.0.2

Development

Successfully merging this pull request may close these issues.

Signal handling mismatch for stopping external VM drivers

4 participants

@unsuman @norio-nomura @jandubois @AkihiroSuda