Validate number of CPUs #4451
Merged
Validate number of CPUs #4451
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-veda
force-pushed
the
validate-cpus
branch
from
3df5934 to
daffb29
Compare
Signed-off-by: Veda Kutagula <veda.kutagula@utexas.edu>
k-veda
force-pushed
the
validate-cpus
branch
from
daffb29 to
2bce4d8
Compare
AkihiroSuda
reviewed
Dec 15, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if numCpus < 0 { |
Member
There was a problem hiding this comment.
Setting to negative numbers is not caught by validation, but will cause a failure to start the VM. This must be caught; limactl edit should never leave lima.yaml in a non-startable state.
Can we just say
-1means the same amount as the host?
Other negative values such as-2should be invalid.
Originally posted by @AkihiroSuda in #3987
Member
There was a problem hiding this comment.
(Can be revisited in another PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #3987. Added code to function
func YQExpressions()to give an error if number of CPU's is negative in filelima/cmd/limactl/editflags/editflags.go.