Skip to content

Multi node k8s test updates and related fixes#4835

Merged
AkihiroSuda merged 1 commit intolima-vm:masterfrom
techthumb:master
Apr 15, 2026
Merged

Multi node k8s test updates and related fixes#4835
AkihiroSuda merged 1 commit intolima-vm:masterfrom
techthumb:master

Conversation

@techthumb
Copy link
Copy Markdown
Contributor

@techthumb techthumb commented Apr 12, 2026

Joining worker nodes to k8s-0 was failing for two reasons:

  1. error: can not mix '--config' with arguments [discovery-token-ca-cert-hash token] was fixed in Update k8s.yaml for bootstrapToken configuration in kubeadm #4829

  2. error: discovery.bootstrapToken.apiServerEndpoint: Invalid value: "https://192.168.104.1:6443": address https://192.168.104.1:6443: too many colons in address

Additionally, there was no failing test to detect this issue.

This MR address 2 and updates the test to detect the issue.

@techthumb techthumb changed the title WIP: Remove 'https://' from kubeadm discovery URL to fix address error Remove 'https://' from kubeadm discovery URL to fix address error Apr 12, 2026
@techthumb techthumb changed the title Remove 'https://' from kubeadm discovery URL to fix address error Multi node k8s test updates and related fixes Apr 12, 2026
@techthumb techthumb marked this pull request as ready for review April 12, 2026 16:22
@techthumb techthumb force-pushed the master branch 2 times, most recently from 06b0e56 to 307f54a Compare April 12, 2026 16:35
@techthumb techthumb marked this pull request as draft April 12, 2026 16:36
@techthumb techthumb marked this pull request as ready for review April 12, 2026 17:03
Comment thread hack/bats/extras/k8s.bats
Comment thread hack/bats/extras/k8s.bats
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the PR description please explain the change

AkihiroSuda
AkihiroSuda previously approved these changes Apr 12, 2026
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda
Copy link
Copy Markdown
Member

Please squash the commits

Signed-off-by: Kunal Parikh <kunal@techthumb.in>
@techthumb
Copy link
Copy Markdown
Contributor Author

Please squash the commits

Done

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit de062bd into lima-vm:master Apr 15, 2026
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants