Skip to content

Wrong dopb in deltav calculation. #154

@tlunttil

Description

@tlunttil

deltav calculation on line 234 of photon.c uses only the microturbulent linewidth (not including thermal broadening). In cases where the thermal linewidth is not insignificant compared to the microturbulent one, deltav currently samples the local lineprofile only near its centre and as a result, calculation of the lineprofile-averaged jbar is biased.

This seems to make quite a big difference in benchmark cases (see #147).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions