uninitialized memory access in grid.c:write_VTK_unstructured_Points

[mwestphal]

After valgrind analysing, it appears there is access to uninitialized memory in
grid.c:write_VTK_unstructured_Points

Memory Use g[i].abun in a loop from 0 to par->ncell

par-ncell defined as par->pIntensity+par->sinkPoints;

g structures is correctly allocated with a size of par->pIntensity+par->sinkPoints

but g structures is not correctly initialized, a part of it is initialized only to par->pIntensity

I guess the fix is to initialized from 0 to par->pIntensity + par->sinkPoints like I propose in my pull request
#1

@christianbrinch is my fix correct ?

[christianbrinch]

Yes

[mwestphal]

no, i've made a mistake in my analysis.
dens and t are indeed initialized from pIntensity to sinkPoint here

but abun is not, in that case, i've added in initialization a abun at 0 from pIntensity to sinkPoints.

it it correct ? should I initialize to another value ?

[christianbrinch]

I am not sure if it matters. the abundance is never used for the sink points anyway.

[mwestphal]

it matters memory wise 👍 , since the value is read and written in the grid file. I initialize to zero then.
mwestphal@29f140d