Closed
Conversation
This model correspond to model 1a and 1b from the van Zadelhoff (2002) paper.
Contributor
Author
|
It seems pretty clear that we won't be able to merge it in time for release 1.6, so I'm removing the milestone. |
The width a=0.15 km/s given by Zadelhoff et al. is a total thermal+turbulent linewidth, so we need to remove the thermal component.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds benchmark models to LIME source code (see #16). These benchmark are meant to test LIME's results throughout the development of the code. The benchmark problems are adapted from van Zadelhoff et al., Astronomy and Astrophysics, 395, p.373-384 (2002). For the moment only the benchmark problem 1 is implemented. See the README for more details.
Note that this PR isn't ready to be merged yet. We first need to: