Merged
Conversation
New image parameters incl, posang, azimuth have been added as an alternative way to rotate the model. The way to select these is a bit primitive: they are each given a default value of -999 and detected values of >-900 for both incl and azimuth will trigger use of these parameters rather than the older theta/phi angles. The zero points and directions of these rotations have been defined according to Attila Juhasz's recommendations in the discussion of lime-rt#63. I modified the model.c to exemplify the new angles instead of the old. Finally, for convenience I added a (commented-out) line in the makefile with a debugging switch.
I also slightly amended the test to decide whether to use theta/phi or the new angles: now all three of the new values must be supplied in order for theta/phi to be set aside and the new angles used.
Contributor
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides the necessary code to implement #63, which seems to have died of loneliness.
Note that I found my final prescription (comment of 9 Aug on the #63 thread) to be in error: the expression for
incMatshould have read