Skip to content

Number of rays no longer scales with edges#191

Merged
allegroLeiden merged 1 commit intolime-rt:masterfrom
tlunttil:fix_160
Nov 17, 2016
Merged

Number of rays no longer scales with edges#191
allegroLeiden merged 1 commit intolime-rt:masterfrom
tlunttil:fix_160

Conversation

@tlunttil
Copy link
Copy Markdown
Contributor

The number of rays per grid point is now set by RAYS_PER_POINT in lime.h, currently set to 200. The number 200 is arbitrary, but the previous ininphot 9 resulted in roughly similar (perhaps slightly smaller) number of rays on average.

Each grid point has (already had) an individual nphot attribute, which is currently set to RAYS_PER_POINT for every non-sink grid point. Currently that is not needed, but it can be useful later when adaptive ray sampling is implemented.

Sampling of frequencies was to some extent tied to the previous 'scale the number of rays according to edges' scheme. I didn't bother trying to recreate that, because the whole frequency integration part will probably be redone soon. Instead, I'm using a very simple uniform sampling, which is more of a place holder rather than something that I'm proposing for real use.

@allegroLeiden
Copy link
Copy Markdown
Contributor

I am a bit uneasy with the uniform frequency sampling - a pseudo-random sampling would have maybe been better - but as you say, it is just a placeholder. I'll merge this and we'll see what sort of output it gives.

@allegroLeiden allegroLeiden merged commit 386b032 into lime-rt:master Nov 17, 2016
@tlunttil
Copy link
Copy Markdown
Contributor Author

I'm currently trying some different frequency sampling methods. In particular, I'm implementing a scheme which traces different frequencies along a single ray simultaneously, so that some of the geometry calculations can be reused. Unfortunately the code structure isn't quite optimal for doing that efficiently. I'll make a new PR if something useful emerges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants