Number of rays no longer scales with edges#191
Merged
allegroLeiden merged 1 commit intolime-rt:masterfrom Nov 17, 2016
tlunttil:fix_160
Merged
Number of rays no longer scales with edges#191allegroLeiden merged 1 commit intolime-rt:masterfrom tlunttil:fix_160
allegroLeiden merged 1 commit intolime-rt:masterfrom
tlunttil:fix_160
Conversation
Contributor
|
I am a bit uneasy with the uniform frequency sampling - a pseudo-random sampling would have maybe been better - but as you say, it is just a placeholder. I'll merge this and we'll see what sort of output it gives. |
Contributor
Author
|
I'm currently trying some different frequency sampling methods. In particular, I'm implementing a scheme which traces different frequencies along a single ray simultaneously, so that some of the geometry calculations can be reused. Unfortunately the code structure isn't quite optimal for doing that efficiently. I'll make a new PR if something useful emerges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The number of rays per grid point is now set by
RAYS_PER_POINTin lime.h, currently set to 200. The number 200 is arbitrary, but the previousininphot 9resulted in roughly similar (perhaps slightly smaller) number of rays on average.Each grid point has (already had) an individual
nphotattribute, which is currently set toRAYS_PER_POINTfor every non-sink grid point. Currently that is not needed, but it can be useful later when adaptive ray sampling is implemented.Sampling of frequencies was to some extent tied to the previous 'scale the number of rays according to edges' scheme. I didn't bother trying to recreate that, because the whole frequency integration part will probably be redone soon. Instead, I'm using a very simple uniform sampling, which is more of a place holder rather than something that I'm proposing for real use.