Closed
Conversation
The new parameter is used to check whether the user provides velocity from the predefined grid.
The default value of the new parameter means that the velocity field obtained with the velocity function but not from the predefined grid.
The code always assumes that if the user supplied the predefined grid then the velocity was taken from this grid. This may be not the case. It is better to perform additional check on whether the velocity field was taken from the predefined grid or was obtained with the velocity function.
The code always assumes that if the user supplied the predefined grid then the velocity was taken from this grid. This may be not the case. It is better to perform additional check on whether the velocity field was taken from the predefined grid or was obtained with the velocity function.
These commits allow the code to check what variables were supplied by the user in the predefined grid. If some variables were not provided in the input file then they will be computed with the model functions. It also important that the code checks whether the velocity field was supplied in the predefined grid. This information is then used in photon and traceray procedures.
Additional notes may be useful for the users who want to change the format of file with the predefined grid.
Contributor
|
I think this goes in the right direction, but I have felt all along that I/O for grid data must be made much more systematic, with a limited number of clearly defined possibilities for which grid attributes are expected to be supplied in a file submitted by the user. My PR #92 sets out such a scheme. |
Contributor
OK, I'm closing this one then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code (photon and traceray procedures) assumes that if the user supplies predefined grid then the velocity field is taken from this grid. The user may want to change the format of file with the predefined grid so that the velocity will not be taken from this file.
These commits allow the code to check whether the user supplies the velocity field with the predefined grid and to use appropriate functions in photon and traceray procedures. With these commits the code also will check whether other physical properties were taken from the input file with predefined grid. It may be useful if the user wants to change the format of the input file.