Skip to content

JAMES-3087 LDAP user listing should filter out users without id field #3172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chibenwa wants to merge 2 commits into from
Closed

JAMES-3087 LDAP user listing should filter out users without id field #3172

chibenwa wants to merge 2 commits into from

Conversation

@chibenwa
Copy link
Member

@chibenwa chibenwa commented Mar 5, 2020

Before that a NPE was returned.

@chibenwa chibenwa added this to the Sprint 15 - Robusta Beans milestone Mar 5, 2020
@chibenwa chibenwa self-assigned this Mar 5, 2020
@chibenwa
Copy link
Member Author

chibenwa commented Mar 5, 2020

test this please

@trantienduchn
Copy link

trantienduchn commented Mar 5, 2020

How about tests for countUsers() ?

@chibenwa
Copy link
Member Author

chibenwa commented Mar 5, 2020 

[cdcf10ea85ca62bd325d372496e5964b2faf5f11] [ERROR] Failures: 
[cdcf10ea85ca62bd325d372496e5964b2faf5f11] [ERROR]   CassandraBlobStoreTest.readBytesShouldPublishReadBytesTimerMetrics 
[cdcf10ea85ca62bd325d372496e5964b2faf5f11] Expected size:<2> but was:<1> in:
[cdcf10ea85ca62bd325d372496e5964b2faf5f11] <[PT0.004687877S, PT0.004020632S]>

unrelated.

test this please

@chibenwa chibenwa added the waiting_merge We are about to merge this! label Mar 6, 2020
@Arsnael
Copy link
Member

Arsnael commented Mar 6, 2020

Merged

@Arsnael Arsnael closed this Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@blackheaven blackheaven blackheaven approved these changes

@trantienduchn trantienduchn trantienduchn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chibenwa chibenwa

Labels

bug priority prod waiting_merge We are about to merge this!

Projects

None yet

Milestone

Sprint 15 - Robusta Beans

Development

Successfully merging this pull request may close these issues.

4 participants

@chibenwa @trantienduchn @Arsnael @blackheaven