Skip to content

Removed return type hint#591

Merged
drewoldag merged 1 commit intomainfrom
awo/no-return-from-fixup
Jan 15, 2026
Merged

Removed return type hint#591
drewoldag merged 1 commit intomainfrom
awo/no-return-from-fixup

Conversation

@drewoldag
Copy link
Copy Markdown
Collaborator

More than anything else, this makes the red squiggly underlines in my IDE go away.

Copilot AI review requested due to automatic review settings January 15, 2026 21:58
@drewoldag drewoldag self-assigned this Jan 15, 2026
@drewoldag drewoldag requested review from mtauraso and removed request for Copilot January 15, 2026 21:59
@drewoldag drewoldag enabled auto-merge (squash) January 15, 2026 22:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.31%. Comparing base (f07063b) to head (8d07324).
⚠️ Report is 228 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files          53       53           
  Lines        5235     5235           
=======================================
  Hits         3262     3262           
  Misses       1973     1973           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@mtauraso mtauraso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@drewoldag drewoldag merged commit 9308a12 into main Jan 15, 2026
16 checks passed
@drewoldag drewoldag deleted the awo/no-return-from-fixup branch January 15, 2026 22:13
@github-actions
Copy link
Copy Markdown

Before [f07063b] After [3c25536] Ratio Benchmark (Parameter)
8.22±0.1ms 8.51±0.2ms 1.04 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(128, 'chromadb')
384±0.6ms 391±3ms 1.02 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(64, 'qdrant')
1.70±0.02s 1.70±0.02s 1.01 benchmarks.time_help
1.69±0.01s 1.71±0.02s 1.01 benchmarks.time_rebuild_manifest_help
33.4±0.06s 33.6±0.1s 1.01 vector_db_benchmarks.VectorDBInsertBenchmarks.time_load_vector_db(16384, 'qdrant')
1.42±0.01s 1.42±0.01s 1.01 vector_db_benchmarks.VectorDBInsertBenchmarks.time_load_vector_db(2048, 'chromadb')
394±5ms 397±2ms 1.01 vector_db_benchmarks.VectorDBInsertBenchmarks.time_load_vector_db(64, 'chromadb')
380±3ms 385±4ms 1.01 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(128, 'qdrant')
8.33±0.1ms 8.44±0.1ms 1.01 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(64, 'chromadb')
56.6±0.6ms 56.4±0.4ms 1 benchmarks.time_import

Click here to view all benchmarks.

gitosaurus pushed a commit that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants