Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a "Core Concepts" section to the Hyrax documentation. The PR creates an introductory page that organizes three essential documentation topics: required inputs for Hyrax, the configuration system, and data flow through the framework.
Changes:
- Added a new
required_input.rstfile explaining the three essential inputs users must provide (model, data, and data preparation function) - Expanded
core_concepts.rstwith an introduction and a table of contents linking to three conceptual documentation pages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/required_input.rst | New documentation page explaining the three essential inputs (model, dataset, and data preparation function) that users must provide to Hyrax |
| docs/core_concepts.rst | Updated to add introductory content and a toctree linking to three core concept pages (required inputs, configuration system, and data flow) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 53 53
Lines 5235 5235
=======================================
Hits 3262 3262
Misses 1973 1973 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gitosaurus
left a comment
There was a problem hiding this comment.
LGTM! Minor feedback only.
Click here to view all benchmarks. |
dougbrn
left a comment
There was a problem hiding this comment.
I think this looks great, in my opinion it would benefit a lot from some short example snippets, or links to other pages with examples (now or sometime later in the doc sprint). Fully optional though and will approve!
|
@dougbrn Good call out here - I've added a little diagram at the top (not code) and I've linked to the getting started docs for specifying the model and dataset. I'll add a link to the to_tensor function when we get a good notebook set up. |
* Scaffolding page for core concepts page. * Added required-inputs page. * Responding to PR feedback. Adding required_input diagram.
Core concepts with links to "what you need to provide", "config system" and "data flow"