Skip to content

Setting preload_cache default to false#670

Merged
drewoldag merged 1 commit intomainfrom
awo/set-pre-cache-default-false
Feb 4, 2026
Merged

Setting preload_cache default to false#670
drewoldag merged 1 commit intomainfrom
awo/set-pre-cache-default-false

Conversation

@drewoldag
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Hyrax’s packaged default runtime configuration to disable dataset cache preloading by default, avoiding the background preload behavior unless explicitly enabled.

Changes:

  • Set [data_set].preload_cache default from true to false in the default config.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.95%. Comparing base (4fa80ad) to head (45a3d7f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   63.54%   62.95%   -0.59%     
==========================================
  Files          58       58              
  Lines        5782     5782              
==========================================
- Hits         3674     3640      -34     
- Misses       2108     2142      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@drewoldag drewoldag merged commit f90813e into main Feb 4, 2026
14 of 15 checks passed
@drewoldag drewoldag deleted the awo/set-pre-cache-default-false branch February 4, 2026 17:44
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

Before [4fa80ad] After [cb9759c] Ratio Benchmark (Parameter)
10.5±0.5ms 9.20±0.07ms ~0.87 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(64, 'chromadb')
failed failed n/a data_cache_benchmarks.DataCacheBenchmarks.time_preload_cache_cifar
failed failed n/a data_cache_benchmarks.DataCacheBenchmarks.track_cache_cifar_hyrax_size_undercount
475±5ms 496±4ms 1.05 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(64, 'qdrant')
3.74G 3.87G 1.04 vector_db_benchmarks.VectorDBInsertBenchmarks.peakmem_load_vector_db(16384, 'qdrant')
471±4ms 491±3ms 1.04 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(128, 'qdrant')
1.88±0.01s 1.89±0.02s 1.01 benchmarks.time_train_help
1.28G 1.29G 1.01 vector_db_benchmarks.VectorDBInsertBenchmarks.peakmem_load_vector_db(2048, 'qdrant')
1.89±0.01s 1.88±0.01s 1.00 benchmarks.time_download_help
1.90±0.03s 1.89±0.01s 1.00 benchmarks.time_help

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants