Update lance_design.md terminology to match codebase#692
Merged
gitosaurus merged 2 commits intodtj-lance-designfrom Feb 11, 2026
Merged
Update lance_design.md terminology to match codebase#692gitosaurus merged 2 commits intodtj-lance-designfrom
gitosaurus merged 2 commits intodtj-lance-designfrom
Conversation
Co-authored-by: gitosaurus <6794831+gitosaurus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update design for LanceDB integration based on feedback
Update lance_design.md terminology to match codebase
Feb 11, 2026
gitosaurus
approved these changes
Feb 11, 2026
gitosaurus
added a commit
that referenced
this pull request
Feb 12, 2026
* Update lance_design.md terminology to match actual codebase Co-authored-by: gitosaurus <6794831+gitosaurus@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: gitosaurus <6794831+gitosaurus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
The design document used
original_configurationterminology that doesn't exist in the actual codebase, risking implementer confusion.Solution Description
Updated all 4 occurrences in
lance_design.mdto use actual names fromsrc/hyrax/data_sets/inference_dataset.py:original_configuration→original_config/original_datasetoriginal_configproperty (returns_original_dataset_config)original_datasetinstance variableoriginal_dataset_config.tomlfilename constantAffected sections:
ResultDatasetdesign details (lines 155-156)Code Quality
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.