Skip to content

Adding excalidraw diagrams.#772

Merged
drewoldag merged 1 commit intomainfrom
awo/adding-excalidraw-diagrams
Mar 12, 2026
Merged

Adding excalidraw diagrams.#772
drewoldag merged 1 commit intomainfrom
awo/adding-excalidraw-diagrams

Conversation

@drewoldag
Copy link
Copy Markdown
Collaborator

I created a bunch of diagrams in excalidraw a while ago, and didn't realize that I could save them not-online.

I've moved them into the repo so that we can use them for documentation or in talks.

@drewoldag drewoldag self-assigned this Mar 11, 2026
Copilot AI review requested due to automatic review settings March 11, 2026 22:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


You can also share your feedback on Copilot code review. Take the survey.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.69%. Comparing base (a83f3da) to head (f7de9d8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   64.69%   64.69%           
=======================================
  Files          61       61           
  Lines        5894     5894           
=======================================
  Hits         3813     3813           
  Misses       2081     2081           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

Before [a83f3da] After [2d0d58b] Ratio Benchmark (Parameter)
failed failed n/a data_cache_benchmarks.DataCacheBenchmarks.time_preload_cache_hsc1k
failed failed n/a data_cache_benchmarks.DataCacheBenchmarks.track_cache_hsc1k_hyrax_size_undercount
failed failed n/a data_request_benchmarks.DatasetRequestBenchmarks.time_request_all_data
2.00±0.03s 2.09±0.04s 1.05 benchmarks.time_database_connection_help
1.48G 1.54G 1.04 vector_db_benchmarks.VectorDBInsertBenchmarks.peakmem_load_vector_db(16384, 'chromadb')
40.5±0.4ms 41.3±0.7ms 1.02 benchmarks.time_nb_obj_dir
2.02±0.02s 2.06±0.04s 1.02 benchmarks.time_visualize_help
10.3±0.02ms 10.5±0.06ms 1.02 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(64, 'chromadb')
438±0.9ms 445±0.4ms 1.02 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(64, 'qdrant')
1.98±0.02s 2.00±0.01s 1.01 benchmarks.time_download_help

Click here to view all benchmarks.

Copy link
Copy Markdown
Collaborator

@aritraghsh09 aritraghsh09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great!

The only comment I have is that we should reuse the figures from the paper when possible (only relevant for 1 diagram in this set probably)

@drewoldag drewoldag merged commit 44da305 into main Mar 12, 2026
9 checks passed
@drewoldag drewoldag deleted the awo/adding-excalidraw-diagrams branch March 12, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants