Skip to content

Adding LanceDB pin to fix tests with NaNs inserted into ResultDatasets#799

Merged
mtauraso merged 1 commit intomainfrom
pin-lancedb-for-nan-issue
Mar 18, 2026
Merged

Adding LanceDB pin to fix tests with NaNs inserted into ResultDatasets#799
mtauraso merged 1 commit intomainfrom
pin-lancedb-for-nan-issue

Conversation

@mtauraso
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 18, 2026 20:56
@mtauraso mtauraso requested a review from drewoldag March 18, 2026 20:57
@mtauraso mtauraso enabled auto-merge (squash) March 18, 2026 20:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the lancedb dependency to a pre-0.30.0 version to preserve NaN handling behavior relied on by Hyrax’s Lance-backed ResultDataset implementation and associated tests.

Changes:

  • Pin lancedb to < 0.30.0 with explanatory comments in pyproject.toml.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread pyproject.toml
Comment on lines +59 to +61
# Pin to before 0.30.0 because version 0.30.0 does not support NaN values anymore
# This issue is NOT noted in release notes (https://github.com/lancedb/lancedb/releases/tag/python-v0.30.0)
# We may need to file a bug
Copy link
Copy Markdown
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.73%. Comparing base (cf9737c) to head (85a34bd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #799   +/-   ##
=======================================
  Coverage   64.73%   64.73%           
=======================================
  Files          61       61           
  Lines        5890     5890           
=======================================
  Hits         3813     3813           
  Misses       2077     2077           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtauraso mtauraso merged commit c885a10 into main Mar 18, 2026
12 of 13 checks passed
@mtauraso mtauraso deleted the pin-lancedb-for-nan-issue branch March 18, 2026 21:02
@github-actions
Copy link
Copy Markdown

Before [cf9737c] After [c9fd49e] Ratio Benchmark (Parameter)
12.7±0.1ms 10.5±0.2ms ~0.83 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(64, 'chromadb')
failed failed n/a data_cache_benchmarks.DataCacheBenchmarks.time_preload_cache_hsc1k
failed failed n/a data_cache_benchmarks.DataCacheBenchmarks.track_cache_hsc1k_hyrax_size_undercount
failed failed n/a data_request_benchmarks.DatasetRequestBenchmarks.time_request_all_data
54.4±0s failed n/a vector_db_benchmarks.VectorDBInsertBenchmarks.time_load_vector_db(16384, 'qdrant')
2.10±0.03s 2.22±0.03s 1.06 benchmarks.time_save_to_database_help
2.08±0.02s 2.17±0.03s 1.05 benchmarks.time_download_help
294±3ms 306±8ms 1.04 benchmarks.time_import
2.08±0.01s 2.16±0.01s 1.04 benchmarks.time_infer_help
2.09±0.01s 2.17±0.03s 1.04 benchmarks.time_lookup_help

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants