Skip to content
This repository was archived by the owner on Dec 1, 2025. It is now read-only.

Conversation

@gitosaurus
Copy link
Contributor

Change Description

Expand and improve the discussion of necessary nested-dask meta= in the quickstart.

Part of the fix to astronomy-commons/lsdb#670 .

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@gitosaurus gitosaurus requested a review from dougbrn May 27, 2025 21:59
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Before [0be141b] After [fe88b10] Ratio Benchmark (Parameter)
283±2ms 284±3ms 1.01 benchmarks.NestedFrameAddNested.time_run
136M 136M 1 benchmarks.NestedFrameAddNested.peakmem_run
139M 138M 1 benchmarks.NestedFrameQuery.peakmem_run
864±10ms 864±2ms 1 benchmarks.NestedFrameQuery.time_run
135M 135M 1 benchmarks.NestedFrameReduce.peakmem_run
291±2ms 291±1ms 1 benchmarks.NestedFrameReduce.time_run

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.78%. Comparing base (0be141b) to head (3318d29).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files           9        9           
  Lines         261      261           
=======================================
  Hits          250      250           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitosaurus This is great, my only issue is that people probably won't read this documentation since nested-dask is effectively deprecated! I think we should preserve this as part of LSDB #680, in the eventual focus on nestedframes within the LSDB docs, but happy to merge this in here too.

@gitosaurus gitosaurus merged commit 028664d into main May 27, 2025
9 checks passed
@gitosaurus gitosaurus deleted the docs-on-meta branch May 27, 2025 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants