-
Notifications
You must be signed in to change notification settings - Fork 1
Restore the ability to read remote directories #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 97.79% 97.33% -0.47%
==========================================
Files 19 19
Lines 2042 2062 +20
==========================================
+ Hits 1997 2007 +10
- Misses 45 55 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Click here to view all benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! This looks good to me, but I have one remaining concern about whether this is supporting more than was supported before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Actually reading directories with column selection doesn't work right now, working on another reimplementation |
|
Reimplemented again, now It is also really poorly tested, but hopefully will be better covered by cloud tests. |
Closes #392