Skip to content

Conversation

@Graciaaa3
Copy link
Collaborator

Adding a documentation notebook for groupby usage within nested-pandas. The notebook contains:

  • working and failing cases of basic aggregations on NestedFrame after groupby.
  • a section discussing the type preservation with groupby object and indexing.
  • some potential use of apply after groupby.

closes #333

Change Description

  • My PR includes a link to the issue that I am addressing

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.27%. Comparing base (d82a63d) to head (1ebedec).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          19       19           
  Lines        2089     2089           
=======================================
  Hits         2032     2032           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Before [ebe6315] <v0.6.2> After [6067b10] Ratio Benchmark (Parameter)
258M 262M 1.02 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
59.8±0.1ms 60.2±0.8ms 1.01 benchmarks.CountNestedBy.time_run
11.1±0.1ms 11.2±0.2ms 1.01 benchmarks.NestedFrameAddNested.time_run
10.7±0.1ms 10.8±0.1ms 1.01 benchmarks.NestedFrameQuery.time_run
1.19±0.01ms 1.21±0.01ms 1.01 benchmarks.NestedFrameReduce.time_run
179M 181M 1.01 benchmarks.ReadFewColumnsHTTPS.peakmem_run
1.98±0.02s 1.99±0.05s 1.01 benchmarks.ReadFewColumnsS3.time_run
135M 135M 1 benchmarks.CountNestedBy.peakmem_run
257M 254M 0.99 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
33.4±0.8ms 33.0±1ms 0.99 benchmarks.AssignSingleDfToNestedSeries.time_run

Click here to view all benchmarks.

@dougbrn
Copy link
Collaborator

dougbrn commented Nov 3, 2025

I added some review comments above, but overall I think the structure of this looks really good @Graciaaa3! As you probably see, the docs builds aren't passing and I suspect that's due to the min/max/mean case in your notebook which is supposed to fail. I added a comment with some potential solutions to that.

@dougbrn
Copy link
Collaborator

dougbrn commented Nov 6, 2025

Also, make sure to add an entry for this notebook into the tutorials.rst file so that this is navigable on the readthedocs site

@Graciaaa3 Graciaaa3 marked this pull request as ready for review November 6, 2025 23:49
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@Graciaaa3 Graciaaa3 requested a review from gitosaurus November 13, 2025 23:06
Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Graciaaa3 Graciaaa3 merged commit 464bffa into main Nov 14, 2025
12 checks passed
@Graciaaa3 Graciaaa3 deleted the groupby_doc branch November 14, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add groupby example to docs

4 participants