-
Notifications
You must be signed in to change notification settings - Fork 1
Documentation notebook for groupby #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 19 19
Lines 2089 2089
=======================================
Hits 2032 2032
Misses 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Click here to view all benchmarks. |
|
I added some review comments above, but overall I think the structure of this looks really good @Graciaaa3! As you probably see, the docs builds aren't passing and I suspect that's due to the min/max/mean case in your notebook which is supposed to fail. I added a comment with some potential solutions to that. |
|
Also, make sure to add an entry for this notebook into the tutorials.rst file so that this is navigable on the readthedocs site |
4f7cfe4 to
eac4581
Compare
dougbrn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
gitosaurus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Adding a documentation notebook for
groupbyusage within nested-pandas. The notebook contains:NestedFrameafter groupby.applyafter groupby.closes #333
Change Description